Looking for system images fails if a file exists in the system-images folder

[ghugues]

Running a simple bazel build command, I had the following error:

INFO: Invocation ID: 3d569451-23c7-4a53-9b2b-c9a8f9928a3b
INFO: Repository rules_android++android_sdk_repository_extension+androidsdk instantiated at:
  <builtin>: in <toplevel>
Repository rule _android_sdk_repository defined at:
  /private/var/tmp/_bazel_xxx/xxxxxx/external/rules_android+/rules/android_sdk_repository/rule.bzl:167:42: in <toplevel>
ERROR: /private/var/tmp/_bazel_xxx/xxxxxx/external/rules_android+/rules/android_sdk_repository/rule.bzl:81:47: An error occurred during the fetch of repository 'rules_android++android_sdk_repository_extension+androidsdk':
   Traceback (most recent call last):
	File "/private/var/tmp/_bazel_xxx/xxxxxx/external/rules_android+/rules/android_sdk_repository/rule.bzl", line 145, column 40, in _android_sdk_repository_impl
		system_images = _find_system_images(repo_ctx, android_sdk_path)
	File "/private/var/tmp/_bazel_xxx/xxxxxx/external/rules_android+/rules/android_sdk_repository/rule.bzl", line 81, column 47, in _find_system_images
		for enabled_entry in api_entry.readdir():
Error in readdir: can't readdir(), not a directory: /Users/xxx/Library/Android/sdk/system-images/.DS_Store

The workaround is simple, just remove the .DS_Store file. But the for loop could simply skip files.

[ted-xie]

The .DS_Store file is a file generated by the Mac OS, IIRC from the file viewer app. See #386 and my response here. The team hasn't had the bandwidth to take this issue on yet, but contributions are welcome.