bazel: simplify done channel rendezvous #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the channel rendezvous to instead of using a buffered channel
with an unergonomical `ch <- struct{}{}` use a `defer close(ch)`
semantic. This change is within its scope of usage isomorphic.
|
Thanks for sending in the PR! Out of curiosity, why were you reviewing this section of the code? |
|
Long story short: I found https://github.com/derivita/bazelpackagesdriver, because I had been interested in golang/go#34341. I did a code study of the implementation of the driver, which sent me here next. I figured that it was using a subprocess to manage interfacing with Bazel, which I confirmed. Was somewhat interested if any creative solution to making the data access more scaleable was found (mediating driver model with Bazel). I figured some of this information may be relevant for adapting this to Bazel’s big brother. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the channel rendezvous to instead of using a buffered channel
with an unergonomical
ch <- struct{}{}use adefer close(ch)semantic. This change is within its scope of usage isomorphic.