-
-
Notifications
You must be signed in to change notification settings - Fork 259
More 21.1.1 distributions #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @helly25, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request extends the available LLVM 21.1.1 distributions by integrating support for two additional platforms: aarch64-pc-windows-msvc and armv7a-linux-gnueabihf. This enhancement broadens the compatibility of the toolchain, allowing it to be used across a wider range of architectures and operating systems.
Highlights
- New LLVM Distributions: Added
clang+llvm-21.1.1-aarch64-pc-windows-msvc.tar.xzandclang+llvm-21.1.1-armv7a-linux-gnueabihf.tar.gzto the list of supported LLVM 21.1.1 distributions. - Toolchain Configuration Update: Updated
toolchain/internal/llvm_distributions.bzlto include the new distribution entries and their corresponding SHA256 checksums.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds two new LLVM distributions for version 21.1.1. The change itself is straightforward, but it necessitates updates to associated golden test files to prevent test failures. A critical review comment has been added to highlight the need to update these files.
|
@fmeum could you please retrigger the failing test, as it had a download issue yesterday? |
No description provided.