Skip to content

Conversation

@helly25
Copy link
Collaborator

@helly25 helly25 commented Sep 8, 2025

Add more 21.1.0 distributions

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @helly25, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the available LLVM 21.1.0 distributions by including support for additional target platforms. This ensures broader compatibility and availability of the specified LLVM version for various build environments.

Highlights

  • New LLVM 21.1.0 Distributions: Added two new LLVM 21.1.0 distribution entries to the _llvm_distributions map: one for aarch64-pc-windows-msvc and another for armv7a-linux-gnueabihf, along with their respective SHA256 hashes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@fmeum fmeum enabled auto-merge (squash) September 8, 2025 09:28
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds two new LLVM 21.1.0 distributions. The changes are correct, but I have a couple of suggestions to improve maintainability and ensure tests pass. I've recommended reordering the entries for this version to be fully alphabetical, aligning with the repository's helper script. I also noted that the test golden files may need to be updated.

@fmeum fmeum merged commit 283c024 into bazel-contrib:master Sep 8, 2025
36 checks passed
@helly25 helly25 mentioned this pull request Sep 18, 2025
helly25 added a commit to helly25/bazel-toolchain that referenced this pull request Sep 28, 2025
Add more 21.1.0 distributions
@helly25 helly25 deleted the more-21.1.0 branch October 9, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants