Pass rlocationpaths to Test Runner #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes paths passed to scalatest Runner that was broken in a recent commit. - Now properly uses rlocationpaths.
liucijus
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed so that paths passed to the Test Runner are in "rlocationpath" form. This should be more correct way to handle these paths as that is what rlocation() expects.
This fixes issue where we couldn't test external repo tests on Windows.
Note: seems to have been chasing this issue in the past (#1598. #1500), hopefully this solves for good.
Motivation
Handle paths in more robust way. And run scalatests from external repos on windows again.