Skip to content

refactor: Use the linkstamps from linker_inputs instead of from cc_linking_context for to support upcoming CcInfo changes #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2025
Merged

refactor: Use the linkstamps from linker_inputs instead of from cc_linking_context for to support upcoming CcInfo changes #3075

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33b19be
Use the linkstamps from linker_inputs instead of from cc_linking_context
comius Jul 10, 2025
a79f88d
Merge branch 'main' into patch-4
rickeylev Aug 16, 2025
b98ef19
Merge branch 'main' into patch-4
aignas Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions python/private/py_executable.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1578,7 +1578,11 @@ def _create_shared_native_deps_dso(
feature_configuration,
requested_features,
cc_toolchain):
linkstamps = py_internal.linking_context_linkstamps(cc_info.linking_context)
linkstamps = [
py_internal.linkstamp_file(linkstamp)
for linker_input in cc_info.linking_context.linker_inputs.to_list()
for linkstamp in linker_input.linkstamps
]

partially_disabled_thin_lto = (
cc_common.is_enabled(
Expand All @@ -1602,10 +1606,7 @@ def _create_shared_native_deps_dso(
for input in cc_info.linking_context.linker_inputs.to_list()
for flag in input.user_link_flags
],
linkstamps = [
py_internal.linkstamp_file(linkstamp)
for linkstamp in linkstamps.to_list()
],
linkstamps = linkstamps,
build_info_artifacts = _get_build_info(ctx, cc_toolchain) if linkstamps else [],
features = requested_features,
is_test_target_partially_disabled_thin_lto = is_test and partially_disabled_thin_lto,
Expand Down