fix(builtin): don't pass kwargs to generated_file_test .update binary #2361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
requested review from
gregmagolan,
mattem and
soldair
as code owners
gregmagolan
approved these changes
Dec 22, 2020
Collaborator
gregmagolan
left a comment
gregmagolan
left a comment
There was a problem hiding this comment.
Could pass size to just the test target as well so it is user configurable?
This allows you to set things like size or timeout to prevent warnings under bazel test --test_verbose_timeout_warnings
alexeagle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test itself just runs diff, so it's always fast. This prevents warnings under bazel test --test_verbose_timeout_warnings
Note that the **kwargs are passed to both the binary and test targets here, so users can't pass this attribute