Skip to content

Conversation

@peakschris
Copy link

@peakschris peakschris commented Sep 30, 2025

This PR fixes two things:

  1. appsettings.json files are not always copied to output directory. This is fixed by adding the appsettings outputs to data.
  2. improve error handling related to failures to copy appsettings
  3. resources named with fully qualified namespace - as suggested by resgen.exe - are not added to the compile line correctly.

Resgen promotes naming the output .resources file with fully qualified namespace such as Company.Department.Class.resources; when files that contain such a dot-qualified namespace are provided use the filename namespace directly rather than attempting to derive it from out_dll.

@peakschris peakschris changed the title Always copy appsetting_files and detect namespace of resources Fix copy of appsetting_files and detect namespace of resources Sep 30, 2025
Copy link
Collaborator

@purkhusid purkhusid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, any chance you could add a test that captures this under dotnet/private/tests/resources?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants