Gaps #147
Open
Gaps #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove DragSortListItem class and accompanying method for creating gaps between list items. A summary: Prior to this commit, each list item was wrapped in a lightweight ViewGroup called DragSortListItem. DSLV would modify the height of the wrapper (leaving the height of the wrapped layout unchanged) to create blank spaces between list items so as to indicate the new position into which the dragged item might be dropped. The new behavior does away with the DragSortListItem wrapper and, instead, shifts the list items away from each other to create the drop/shuffle gaps. A few advantages over the old method come to mind: - Removes unnecessary added layer in the View hierarchy. - Item shuffling avoids layout passes (unless scrolling), simply calling `invalidate()`. - Code is more elegant and maintainable (previous hacks to improve shuffling and scrolling smoothness magically disappear).
Replace bitmask for customizing each Gap with a simple minimum height parameter. Bitmask was overkill, adding unnecessary complication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.