Skip to content

Conversation

@bastibe
Copy link
Owner

@bastibe bastibe commented Dec 8, 2014

The README should have links to the latest source release and PyPi.

@bastibe bastibe self-assigned this Mar 29, 2014
@mgeier
Copy link
Contributor

mgeier commented Apr 27, 2014

Instead of "BSD licensed" you should be probably more specific ("3-clause BSD license" or whatever the exact name is).

@bastibe
Copy link
Owner Author

bastibe commented Apr 28, 2014

Also, we should add a note that libsndfile is LGPL.

@bastibe
Copy link
Owner Author

bastibe commented May 27, 2014

Also, provide a changelog.

@mgeier
Copy link
Contributor

mgeier commented Jun 2, 2014

I think it's also worth changing from Markdown to reStructuredText, because then the README can be re-used in the Sphinx documentation and on PyPI.

I tried this and it works great, all three pages use the same README.rst: http://github.com/spatialaudio/schunk/, http://schunk.rtfd.org/, https://pypi.python.org/pypi/SchunkMotionProtocol

@bastibe
Copy link
Owner Author

bastibe commented Jun 6, 2014

Sigh. I vastly prefer Markdown over RST for writing. But since the Python community has converged on RST, I agree. Maybe we can automate at least part of the conversion with pandoc.

The Github RST renderer used to be somewhat mediocre, but for simple formatting in the README it should work fine.

@mgeier mgeier mentioned this pull request Jun 18, 2014
@mgeier
Copy link
Contributor

mgeier commented Jul 2, 2014

We should add an example similar to this (see #35):

import numpy as np
import pysoundfile as sf

rms = [np.sqrt(np.mean(b**2)) for b in sf.blocks('myfile.wav', blocksize=1024, overlap=512)]

It would be better if it could be even shorter and more concise, ideally the line should have a length of no more than 79 characters.
Probably we could drop the overlap in the example.

@bastibe
Copy link
Owner Author

bastibe commented Jul 10, 2014

We should add an example like this to the README:

format = {'format':'RAW', 'subtype':'FLOAT', 'endian':'FILE'}
sf.write(data, 'myfile.raw', **format)
data = sf.read('myfile.raw', dtype='float32', **format)

as discussed in #54

@mgeier mgeier mentioned this pull request Jul 16, 2014
@mgeier mgeier added the docs label Aug 15, 2014
@mgeier mgeier modified the milestone: 0.6.0 Oct 26, 2014
@mgeier mgeier mentioned this pull request Nov 15, 2014
@mgeier
Copy link
Contributor

mgeier commented Nov 23, 2014

We should add the exact commands how to install PySoundFile using pip, because for new users that's not at all obvious (I know that from my own experience).
Especially, we should also advertise the --user option:

pip install PySoundFile --user

We could then add how it can be installed system-wide by removing --user from the command (assuming the user has the appropriate rights), but I think the user installation should be the default, since no special access rights are needed.

In addition, we should also mention how to install pip itself, e.g. by linking to http://pip.readthedocs.org/en/latest/installing.html.

It may also be that users have pip installed but no setuptools, then they'll have to install it before:

pip install setuptools --user

The part about python setup.py install should also include the --user option and it should explain that it has to be called in the PySoundFile/ directory (or with version number?) after unpacking the tarball (give link to PyPI).

We could also give the commands for cloning the Git repository and for python setup.py develop, but this might be better shown at a different place, see #66.

@bastibe
Copy link
Owner Author

bastibe commented Dec 8, 2014

Did I miss anything crucial?

README.rst Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"documentation" is an old branch. The pages on readthedocs were still available, but after a reload, they are not anymore. For now, there is only "latest", but as soon as 0.6.0 is out, it will also be available there.

This should be the correct address: http://pysoundfile.readthedocs.org/, no need to give a separate link name.

I personally prefer the short form http://pysoundfile.rtfd.org/, but that's of course a matter of taste.

In any case, we should use the same link everywhere (currently in pysoundfile.py I used the short version).

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the f in rtfd. I just generally dislike swearing in official communication. Also, readthedocs is what is shown in the browser URL.

@bastibe
Copy link
Owner Author

bastibe commented Dec 10, 2014

Can we merge this?

@mgeier
Copy link
Contributor

mgeier commented Dec 10, 2014

As soon as you remove the lie about automatically closing the file ...

@bastibe
Copy link
Owner Author

bastibe commented Dec 16, 2014

How about this:

If a file is opened, it is kept open for as long as the SoundFile object exists. The file is closed when the object is garbage collected, but you should use the close() method or the context manager to close the file explicitly:

Is this an acceptable compromise?

@mgeier
Copy link
Contributor

mgeier commented Dec 16, 2014

Yes, I guess this would be acceptable.

It is still unnecessarily complicated and potentially confusing, but at least it is the truth (as far as I can tell) and it gives the right recommendation to our users!

@bastibe bastibe merged commit 8d9922b into master Dec 17, 2014
@bastibe bastibe deleted the readme branch April 25, 2016 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants