-
Notifications
You must be signed in to change notification settings - Fork 121
Update README #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README #26
Conversation
|
Instead of "BSD licensed" you should be probably more specific ("3-clause BSD license" or whatever the exact name is). |
|
Also, we should add a note that libsndfile is LGPL. |
|
Also, provide a changelog. |
|
I think it's also worth changing from Markdown to reStructuredText, because then the README can be re-used in the Sphinx documentation and on PyPI. I tried this and it works great, all three pages use the same |
|
Sigh. I vastly prefer Markdown over RST for writing. But since the Python community has converged on RST, I agree. Maybe we can automate at least part of the conversion with pandoc. The Github RST renderer used to be somewhat mediocre, but for simple formatting in the README it should work fine. |
|
We should add an example similar to this (see #35): import numpy as np
import pysoundfile as sf
rms = [np.sqrt(np.mean(b**2)) for b in sf.blocks('myfile.wav', blocksize=1024, overlap=512)]It would be better if it could be even shorter and more concise, ideally the line should have a length of no more than 79 characters. |
|
We should add an example like this to the README: format = {'format':'RAW', 'subtype':'FLOAT', 'endian':'FILE'}
sf.write(data, 'myfile.raw', **format)
data = sf.read('myfile.raw', dtype='float32', **format)as discussed in #54 |
|
We should add the exact commands how to install PySoundFile using We could then add how it can be installed system-wide by removing In addition, we should also mention how to install It may also be that users have The part about We could also give the commands for cloning the Git repository and for |
|
Did I miss anything crucial? |
README.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"documentation" is an old branch. The pages on readthedocs were still available, but after a reload, they are not anymore. For now, there is only "latest", but as soon as 0.6.0 is out, it will also be available there.
This should be the correct address: http://pysoundfile.readthedocs.org/, no need to give a separate link name.
I personally prefer the short form http://pysoundfile.rtfd.org/, but that's of course a matter of taste.
In any case, we should use the same link everywhere (currently in pysoundfile.py I used the short version).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the f in rtfd. I just generally dislike swearing in official communication. Also, readthedocs is what is shown in the browser URL.
|
Can we merge this? |
|
As soon as you remove the lie about automatically closing the file ... |
|
How about this:
Is this an acceptable compromise? |
|
Yes, I guess this would be acceptable. It is still unnecessarily complicated and potentially confusing, but at least it is the truth (as far as I can tell) and it gives the right recommendation to our users! |
The README should have links to the latest source release and PyPi.