Skip to content

shellcheck: add code actions to disable rule #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

shellcheck: add code actions to disable rule #1069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/__tests__/server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ describe('server', () => {
{} as any,
)

expect(result).toHaveLength(1)
expect(result).toHaveLength(3)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us check what all the code actions are about. Consider just doing a snapshot test of the entire result object.

const codeAction = (result as CodeAction[])[0]
expect(codeAction.diagnostics).toEqual([fixableDiagnostic])
expect(codeAction.diagnostics).toEqual([fixableDiagnostic])
Expand Down
2 changes: 1 addition & 1 deletion server/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ export default class BashServer {

const codeActions = params.context.diagnostics
.map(({ data }) => codeActionsForUri[data?.id])
.filter((action): action is LSP.CodeAction => action != null)
.flat()

logger.debug(`onCodeAction: found ${codeActions.length} code action(s)`)

Expand Down
Loading