Skip to content

fix: serialize item of type array with zero #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: serialize item of type array with zero #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/serializer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ serializer.buildKey = function (hashKey, rangeKey, schema) {

serializer.serializeItem = function (schema, item, options = {}) {
var serialize = function (value, datatypes = {}) {
if(!value) {
if(value === null) {
return null;
}

Expand Down
16 changes: 16 additions & 0 deletions test/serializer-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,22 @@ describe('Serializer', function () {
item.objects.should.eql([{number: 10, string: 'd'}]);
});

it('should serialize number array with zeros', function () {
var config = {
hashKey: 'id',
schema : {
id : Joi.number(),
resolution : Joi.array().items(Joi.number()).min(2).max(2),
}
};

var s = new Schema(config);

var item = serializer.serializeItem(s, {id: 1, resolution: [0, 0]});

item.should.eql({id: 1, resolution: [0, 0]});
});

it('should return empty when serializing null value', function () {
var config = {
hashKey: 'email',
Expand Down