Skip to content

Conversation

@seanpdoyle
Copy link
Collaborator

The changes proposed to
action_text-trix/app/assets/javascripts/trix.js were generated by executing the following:

yarn build

To reduce the risk of future commits' outputs being excluded from the commits that introduce them, this commit introduces some git commands to the .github/workflows/ci.yml file to fail CI builds when yarn build creates changes that are not already checked into the git commit. The commands are lifted directly from the hotwired/turbo-rails version of this file.

@seanpdoyle seanpdoyle force-pushed the fix-action_text-trix-assets branch 3 times, most recently from 5e6ee85 to ff433f4 Compare November 1, 2025 23:43
The changes proposed to
`action_text-trix/app/assets/javascripts/trix.js` were generated by
executing the following:

```sh
yarn build
```

To reduce the risk of future commits' outputs being excluded from the
commits that introduce them, this commit introduces some `git` commands
to the `.github/workflows/ci.yml` file to fail CI builds when `yarn
build` creates changes that are not already checked into the git commit.
The commands are lifted directly from the [hotwired/turbo-rails][]
version of this file.

[hotwired/turbo-rails]: https://github.com/hotwired/turbo-rails/blob/v2.0.20/.github/workflows/ci.yml#L48-L51
@seanpdoyle seanpdoyle force-pushed the fix-action_text-trix-assets branch from ff433f4 to 835d7d5 Compare November 1, 2025 23:59
@jorgemanrubia jorgemanrubia merged commit 1aa6c54 into basecamp:main Nov 3, 2025
12 checks passed
@seanpdoyle seanpdoyle deleted the fix-action_text-trix-assets branch November 3, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants