Skip to content

Merge Attrs and Methods when compatible #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bcdanieldickison wants to merge 1 commit into
base: merge-namespaces
Choose a base branch
from
Open

Merge Attrs and Methods when compatible #2

bcdanieldickison wants to merge 1 commit into from

Conversation

@bcdanieldickison
Copy link

@bcdanieldickison bcdanieldickison commented Sep 23, 2025

This builds on Shopify#513 to merge Methods and Attrs when they are compatible, e.g. attr_writer :foo with def foo=(val).

This was referenced Sep 23, 2025
Open
Open
@bcdanieldickison
Merge Attrs and Methods when possible
a6862f5 
Fix merge node logic for struct fields and others

Rubocop autofixes

Change return type of merge_nodes so it's not a ? method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bcdanieldickison