Use Java crash handler on not extracted libraries #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rick-bt
reviewed
Jun 14, 2024
rick-bt
reviewed
Jun 14, 2024
Contributor
rick-bt
left a comment
rick-bt
left a comment
There was a problem hiding this comment.
Runtime/Native/Android/NativeClient.cs#255
When we Directory.CreateDirectory(databasePath), can we check that it was created successfully? Would be helpful to know if that create failed.
rick-bt
approved these changes
Jun 14, 2024
Collaborator
Author
Directory.CreateDirectory ensures that the directory exists after it is called. Its in the c# implementation |
perf2711
reviewed
Jun 17, 2024
perf2711
approved these changes
Jun 17, 2024
konraddysput
deleted the
improvement/java-crash-handler-on-not-extracted-libraries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This update allows using java crash handler when the native libraries are not extracted. This change only works on Android.
In the current implementation, we're using Java crash handler as a fallback function. In most cases, we know that our native crash handler should be available and we know most of our clients might not have proguard configuration set up by default
ref: BT-2979