node: reduce breadcrumb size #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perf2711
force-pushed
the
feature/BT-718-reduce-breadcrumb-size
branch
from
6c41841 to
5b03f4d
Compare
perf2711
force-pushed
the
feature/BT-718-reduce-breadcrumb-size--node
branch
from
d4409e1 to
8555396
Compare
perf2711
force-pushed
the
feature/BT-718-reduce-breadcrumb-size
branch
from
84f390a to
8d4594f
Compare
perf2711
force-pushed
the
feature/BT-718-reduce-breadcrumb-size--node
branch
from
1b84aaa to
0059123
Compare
perf2711
changed the title
|
|
||
| return function lengthChunkSplitter(data) { | ||
| const remainingLength = maxLength - seen; | ||
| if (data.length <= remainingLength) { |
There was a problem hiding this comment.
its weird that later we respect wholeLines information but when the data.length <= remainingLenght we don't. Actually why?
There was a problem hiding this comment.
because if all data fits into remainingLength, we don't need to split it. Ergo, line splitting does not occur.
| /** | ||
| * Splits data into chunks with maximum length. | ||
| * @param maxLength Maximum length of one chunk. | ||
| * @param wholeLines If `true`, will split chunks before newlines, so whole lines are passed to the chunk. |
There was a problem hiding this comment.
can we add a description for skip and break?
Comment on lines
121
to
122
| return id; | ||
| } |
There was a problem hiding this comment.
In the past id meant the id of the added breadcrumb. The breadcrumb id is no in the breadcrumb file. Should we return undefined instead? Or something that indicates that the breadcrumb was not added?
There was a problem hiding this comment.
Updated so it returns undefined. sdk-core will also handle this.
konraddysput
approved these changes
Sep 13, 2024
perf2711
force-pushed
the
feature/BT-718-reduce-breadcrumb-size--node
branch
from
3acd0ca to
800f54f
Compare
Base automatically changed from
feature/BT-718-reduce-breadcrumb-size
to
main
September 26, 2024 14:58
perf2711
force-pushed
the
feature/BT-718-reduce-breadcrumb-size--node
branch
from
800f54f to
7d75b24
Compare
…for FileBreadcrumbsStorage
…ceAttachmentProvider
perf2711
force-pushed
the
feature/BT-718-reduce-breadcrumb-size--node
branch
from
7d75b24 to
4f54ec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #228 for Node.