forked from TheAlgorithms/C-Plus-Plus
-
Notifications
You must be signed in to change notification settings - Fork 0
Major rework to improve code quality and add automation checks (#805) #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* delete secant method - it is identical to regula falsi * document + improvize root finding algorithms * attempt to document gaussian elimination * added file brief * commented doxygen-mainpage, added files-list link * corrected files list link path * files-list link correction - this time works :) * document successive approximations * cleaner equation * updating DIRECTORY.md * documented kmp string search * document brute force string search * document rabin-karp string search * fixed mainpage readme * doxygen v1.8.18 will suppress out the #minipage in the markdown * cpplint correction for header guard style * github action to auto format source code per cpplint standard * updated setting to add 1 space before `private` and `public` keywords * auto rename files and auto format code * added missing "run" for step * corrected asignmemt operation * fixed trim and assign syntax * added git move for renaming bad filenames * added missing pipe for trim * added missing space * use old and new fnames * store old fname using echo * move files only if there is a change in filename * put old filenames in quotes * use double quote for old filename * escape double quotes * remove old_fname * try escape characters and echo" * add file-type to find * cleanup echo * ensure all trim variables are also in quotes * try escape -quote again * remove second escpe quote * use single quote for first check * use carets instead of quotes * put variables in brackets * remove -e from echo * add debug echos * try print0 flag * find command with while instead of for-loop * find command using IFS instead * 🎉 IFS fix worked - escaped quotes for git mv * protetc each word in git mv .. * filename exists in lower cases - renamed * 🎉 git push enabled * updating DIRECTORY.md * git pull & then push * formatting filenames d7af6fd * formatting source-code for d7af6fd * remove allman break before braces * updating DIRECTORY.md * added missing comma lost in previous commit * orchestrate all workflows * fix yml indentation * force push format changes, add title to DIRECTORY.md * pull before proceeding * reorganize pull commands * use master branches for actions * rename .cc files to .cpp * added class destructor to clean up dynamic memory allocation * rename to awesome workflow * commented whole repo cpplint - added modified files lint check * removed need for cpplint * attempt to use actions/checkout@master * temporary: no dependency on cpplint * formatting filenames 153fb7b * formatting source-code for 153fb7b * updating DIRECTORY.md * fix diff filename * added comments to the code * added test case * formatting source-code for a850308 * updating DIRECTORY.md * added machine learning folder * added adaline algorithm * updating DIRECTORY.md * fixed issue [LWG2192](https://cplusplus.github.io/LWG/issue2192) for std::abs on MacOS * add cmath for same bug: [LWG2192](https://cplusplus.github.io/LWG/issue2192) for std::abs on MacOS * formatting source-code for f8925e4 * use STL's inner_product * formatting source-code for f94a330 * added range comments * define activation function * use equal initial weights * change test2 function to predict * activation function not friend * previous commit correction * added option for predict function to return value before applying activation function as optional argument * added test case to classify points lying within a sphere * improve documentation for adaline * formatting source-code for 15ec4c3 * added cmake to geometry folder * added algorithm include for std::max * add namespace - machine_learning * add namespace - statistics * add namespace - sorting * added sorting algos to namespace sorting * added namespace string_search * formatting source-code for fd69530 * added documentation to string_search namespace * feat: Add BFS and DFS algorithms to check for cycle in a directed graph * Remove const references for input of simple types Reason: overhead on access * fix bad code sorry for force push * Use pointer instead of the non-const reference because apparently google says so. * Remove a useless and possibly bad Graph constuctor overload * Explicitely specify type of vector during graph instantiation * updating DIRECTORY.md * find openMP before adding subdirectories * added kohonen self organizing map * updating DIRECTORY.md * remove older files and folders from gh-pages before adding new files * remove chronos library due to inacceptability by cpplint * use c++ specific static_cast instead * initialize radom number generator * updated image links with those from CPP repository * rename computer.... folder to numerical methods * added durand kerner method for root computation for arbitrarily large polynomials * fixed additional comma * fix cpplint errors * updating DIRECTORY.md * convert to function module * update documentation * move openmp to main loop * added two test cases * use INT16_MAX * remove return statement from omp-for loop and use "break" * run tests when no input is provided and skip tests when input polynomial is provided * while loop cannot have break - replaced with continue and check is present in the main while condition * (1) break while loop (2) skip runs on break_loop instead of hard-break * add documentation images * use long double for errors and tolerance checks * make iterator variable i local to threads * add critical secions to omp threads * bugfix: move file writing outside of the parallel loop othersie, there is no gurantee of the order of roots written to file * rename folder to data_structures * updating DIRECTORY.md * fix ambiguous symbol `size` * add data_structures to cmake * docs: enable tree view, add timestamp in footer, try clang assistaed parsing * doxygen - open links in external window * remove invalid parameter from function docs * use HTML5 img tag to resize images * move file to proper folder * fix documentations and cpplint * formatting source-code for aacaf98 * updating DIRECTORY.md * cpplint: add braces for multiple statement if * add explicit link to badges * remove duplicate line Signed-off-by: Krishna Vedala <[email protected]> * remove namespace indentation * remove file associations in settings * add author name * enable cmake in subfolders of data_structures * create and link object file * cpp lint fixes and instantiate template classes * cpp lint fixes and instantiate template classes Signed-off-by: Krishna Vedala <[email protected]> * cpplint - ignore `build/include` Signed-off-by: Krishna Vedala <[email protected]> * disable redundant gcc compilation in cpplint workflow Signed-off-by: Krishna Vedala <[email protected]> * template header files contain function codes as well and removed redundant subfolders Signed-off-by: Krishna Vedala <[email protected]> * updating DIRECTORY.md * remove semicolons after functions in a class Signed-off-by: Krishna Vedala <[email protected]> * cpplint header guard style Signed-off-by: Krishna Vedala <[email protected]> * remove semilon Signed-off-by: Krishna Vedala <[email protected]> * added LU decomposition algorithm Signed-off-by: Krishna Vedala <[email protected]> * added QR decomposition algorithm Signed-off-by: Krishna Vedala <[email protected]> * use QR decomposition to find eigen values Signed-off-by: Krishna Vedala <[email protected]> * updating DIRECTORY.md * use std::rand for thread safety Signed-off-by: Krishna Vedala <[email protected]> * move srand to main() Signed-off-by: Krishna Vedala <[email protected]> * cpplint braces correction Signed-off-by: Krishna Vedala <[email protected]> * updated eigen value documentation Signed-off-by: Krishna Vedala <[email protected]> * fix matrix shift doc Signed-off-by: Krishna Vedala <[email protected]> * rename CONTRIBUTION.md to CONTRIBUTING.md #836 * remove 'sort alphabetical order' check * added documentation check * remove extra paranthesis * added gitpod * added gitpod link from README * attempt to add vscode gitpod extensions * update gitpod extensions * add gitpod extensions cmake-tools and git-graph * remove gitpod init and add commands * use init to one time install doxygen, graphviz, cpplint * use gitpod dockerfile * add ninja build system to docker * remove configure task * add github prebuild specs to gitpod * disable gitpod addcommit * update documentation for kohonen_som * added ode solve using forward euler method * added mid-point euler ode solver * fixed itegration step equation * added semi-implicit euler ODE solver * updating DIRECTORY.md * fix cpplint issues - lines 117 and 124 * added documentation to ode group * corrected semi-implicit euler function * updated docs and test cases better structure * replace `free` with `delete` operator * formatting source-code for f55ab50 * updating DIRECTORY.md * main function must return * added machine learning group * added kohonen som topology algorithm * fix graph image path * updating DIRECTORY.md * fix braces * use snprintf instead of sprintf * use static_cast * hardcode character buffer size * fix machine learning groups in documentation * fix missing namespace function * replace kvedala fork references to TheAlgorithms * fix bug in counting_sort Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: Anmol3299 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete secant method - it is identical to regula falsi
document + improvize root finding algorithms
attempt to document gaussian elimination
added file brief
commented doxygen-mainpage, added files-list link
corrected files list link path
files-list link correction - this time works :)
document successive approximations
cleaner equation
updating DIRECTORY.md
documented kmp string search
document brute force string search
document rabin-karp string search
fixed mainpage readme
doxygen v1.8.18 will suppress out the #minipage in the markdown
cpplint correction for header guard style
github action to auto format source code per cpplint standard
updated setting to add 1 space before
privateandpublickeywordsauto rename files and auto format code
added missing "run" for step
corrected asignmemt operation
fixed trim and assign syntax
added git move for renaming bad filenames
added missing pipe for trim
added missing space
use old and new fnames
store old fname using echo
move files only if there is a change in filename
put old filenames in quotes
use double quote for old filename
escape double quotes
remove old_fname
try escape characters and echo"
add file-type to find
cleanup echo
ensure all trim variables are also in quotes
try escape -quote again
remove second escpe quote
use single quote for first check
use carets instead of quotes
put variables in brackets
remove -e from echo
add debug echos
try print0 flag
find command with while instead of for-loop
find command using IFS instead
🎉 IFS fix worked - escaped quotes for git mv
protetc each word in git mv ..
filename exists in lower cases - renamed
🎉 git push enabled
updating DIRECTORY.md
git pull & then push
formatting filenames d7af6fd
formatting source-code for d7af6fd
remove allman break before braces
updating DIRECTORY.md
added missing comma lost in previous commit
orchestrate all workflows
fix yml indentation
force push format changes, add title to DIRECTORY.md
pull before proceeding
reorganize pull commands
use master branches for actions
rename .cc files to .cpp
added class destructor to clean up dynamic memory allocation
rename to awesome workflow
commented whole repo cpplint - added modified files lint check
removed need for cpplint
attempt to use actions/checkout@master
temporary: no dependency on cpplint
formatting filenames 153fb7b
formatting source-code for 153fb7b
updating DIRECTORY.md
fix diff filename
added comments to the code
added test case
formatting source-code for a850308
updating DIRECTORY.md
added machine learning folder
added adaline algorithm
updating DIRECTORY.md
fixed issue LWG2192 for std::abs on MacOS
add cmath for same bug: LWG2192 for std::abs on MacOS
formatting source-code for f8925e4
use STL's inner_product
formatting source-code for f94a330
added range comments
define activation function
use equal initial weights
change test2 function to predict
activation function not friend
previous commit correction
added option for predict function to return value before applying activation function as optional argument
added test case to classify points lying within a sphere
improve documentation for adaline
formatting source-code for 15ec4c3
added cmake to geometry folder
added algorithm include for std::max
add namespace - machine_learning
add namespace - statistics
add namespace - sorting
added sorting algos to namespace sorting
added namespace string_search
formatting source-code for fd69530
added documentation to string_search namespace
feat: Add BFS and DFS algorithms to check for cycle in a directed graph
Remove const references for input of simple types
Reason: overhead on access
sorry for force push
because apparently google says so.
Remove a useless and possibly bad Graph constuctor overload
Explicitely specify type of vector during graph instantiation
updating DIRECTORY.md
find openMP before adding subdirectories
added kohonen self organizing map
updating DIRECTORY.md
remove older files and folders from gh-pages before adding new files
remove chronos library due to inacceptability by cpplint
use c++ specific static_cast instead
initialize radom number generator
updated image links with those from CPP repository
rename computer.... folder to numerical methods
added durand kerner method for root computation for arbitrarily large polynomials
fixed additional comma
fix cpplint errors
updating DIRECTORY.md
convert to function module
update documentation
move openmp to main loop
added two test cases
use INT16_MAX
remove return statement from omp-for loop and use "break"
run tests when no input is provided and skip tests when input polynomial is provided
while loop cannot have break - replaced with continue and check is present in the main while condition
(1) break while loop (2) skip runs on break_loop instead of hard-break
add documentation images
use long double for errors and tolerance checks
make iterator variable i local to threads
add critical secions to omp threads
bugfix: move file writing outside of the parallel loop
othersie, there is no gurantee of the order of roots written to file
rename folder to data_structures
updating DIRECTORY.md
fix ambiguous symbol
sizeadd data_structures to cmake
docs: enable tree view, add timestamp in footer, try clang assistaed parsing
doxygen - open links in external window
remove invalid parameter from function docs
use HTML5 img tag to resize images
move file to proper folder
fix documentations and cpplint
formatting source-code for aacaf98
updating DIRECTORY.md
cpplint: add braces for multiple statement if
add explicit link to badges
remove duplicate line
Signed-off-by: Krishna Vedala [email protected]
remove namespace indentation
remove file associations in settings
add author name
enable cmake in subfolders of data_structures
create and link object file
cpp lint fixes and instantiate template classes
cpp lint fixes and instantiate template classes
Signed-off-by: Krishna Vedala [email protected]
build/includeSigned-off-by: Krishna Vedala [email protected]
Signed-off-by: Krishna Vedala [email protected]
Signed-off-by: Krishna Vedala [email protected]
updating DIRECTORY.md
remove semicolons after functions in a class
Signed-off-by: Krishna Vedala [email protected]
Signed-off-by: Krishna Vedala [email protected]
Signed-off-by: Krishna Vedala [email protected]
Signed-off-by: Krishna Vedala [email protected]
Signed-off-by: Krishna Vedala [email protected]
Signed-off-by: Krishna Vedala [email protected]
updating DIRECTORY.md
use std::rand for thread safety
Signed-off-by: Krishna Vedala [email protected]
Signed-off-by: Krishna Vedala [email protected]
Signed-off-by: Krishna Vedala [email protected]
Signed-off-by: Krishna Vedala [email protected]
Signed-off-by: Krishna Vedala [email protected]
rename CONTRIBUTION.md to CONTRIBUTING.md Change the contributing guidelines name TheAlgorithms/C-Plus-Plus#836
remove 'sort alphabetical order' check
added documentation check
remove extra paranthesis
added gitpod
added gitpod link from README
attempt to add vscode gitpod extensions
update gitpod extensions
add gitpod extensions cmake-tools and git-graph
remove gitpod init and add commands
use init to one time install doxygen, graphviz, cpplint
use gitpod dockerfile
add ninja build system to docker
remove configure task
add github prebuild specs to gitpod
disable gitpod addcommit
update documentation for kohonen_som
added ode solve using forward euler method
added mid-point euler ode solver
fixed itegration step equation
added semi-implicit euler ODE solver
updating DIRECTORY.md
fix cpplint issues - lines 117 and 124
added documentation to ode group
corrected semi-implicit euler function
updated docs and test cases better structure
replace
freewithdeleteoperatorformatting source-code for f55ab50
updating DIRECTORY.md
main function must return
added machine learning group
added kohonen som topology algorithm
fix graph image path
updating DIRECTORY.md
fix braces
use snprintf instead of sprintf
use static_cast
hardcode character buffer size
fix machine learning groups in documentation
fix missing namespace function
replace kvedala fork references to TheAlgorithms
fix bug in counting_sort
Co-authored-by: github-actions ${GITHUB_ACTOR}@users.noreply.github.com
Co-authored-by: Anmol3299 [email protected]
Description of Change
Checklist
Notes: