-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Amend provisioned concurrency examples and templates to work for false condition #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Codecov Report
@@ Coverage Diff @@
## develop #1288 +/- ##
========================================
Coverage 94.43% 94.43%
========================================
Files 78 78
Lines 4352 4352
Branches 860 860
========================================
Hits 4110 4110
Misses 115 115
Partials 127 127 Continue to review full report at Codecov.
|
Changing base to develop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@me2resh Thanks for submitting this change! Having good examples is really important and this change ensures that. However, I think unintended changes have snuck in from the current merge into develop, can you rebase your changes against the latest develop and make sure only the ones you intend are in this pr?
…nedConcurrencyConfig with a condition on the parent property
…ionedConcurrencyConfig on the parent property
Hi @praneetap, the branch currently is rebased against the latest develop and has only my intended changes. please re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!!
Issue #, if available:
None
Description of changes:
The current examples and templates for lambda provisioned concurrency works fine for a true valid condition, but if the condition in the example is false, it will fail with and error because the parent property ProvisionedConcurrencyConfig will still be present, but will have no child configuration settings.
Description of how you validated changes:
In the example templates, change the condition AliasProvisionedConcurrencyEnabled to false
Then when you try to deploy the template, cloudformation deploy will fail with the error:
I also added a missing condition in the lambda_edge/template.yaml
Checklist:
make pr
passesexamples/2016-10-31
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.