fix: amend provisioned concurrency examples and templates to work for false condition (#1288)

Author: me2resh

examples/2016-10-31/lambda_edge/README.md

@@ -30,8 +30,10 @@ LambdaEdgeFunctionSample:
         Timeout: 5
         # More info at https://github.com/awslabs/serverless-application-model/blob/master/docs/safe_lambda_deployments.rst
         AutoPublishAlias: live 
-        ProvisionedConcurrencyConfig:
-          ProvisionedConcurrentExecutions: !If [AliasProvisionedConcurrencyEnabled, !Ref ProvisionedConcurrency, !Ref 'AWS::NoValue']
+        ProvisionedConcurrencyConfig: !If
+            - AliasProvisionedConcurrencyEnabled
+            - ProvisionedConcurrentExecutions: !Ref ProvisionedConcurrency
+            - !Ref 'AWS::NoValue'
 ```
 
 We must also create a custom IAM Role which allows `lambda.amazonaws.com` and `edgelambda.amazonaws.com` services to assume the role and execute the function.

examples/2016-10-31/lambda_edge/template.yaml

@@ -12,12 +12,15 @@ Parameters:
       - true
       - false
     Default: true
-
+Conditions:
+  AliasProvisionedConcurrencyEnabled: !Equals [!Ref EnableAliasProvisionedConcurrency, true]
 Globals:
 
   Function:
-    ProvisionedConcurrencyConfig:
-      ProvisionedConcurrentExecutions: !If [AliasProvisionedConcurrencyEnabled, !Ref ProvisionedConcurrency, !Ref 'AWS::NoValue']
+    ProvisionedConcurrencyConfig: !If
+        - AliasProvisionedConcurrencyEnabled
+        - ProvisionedConcurrentExecutions: !Ref ProvisionedConcurrency
+        - !Ref 'AWS::NoValue'
 
 Resources:
 

tests/translator/input/error_function_with_no_alias_provisioned_concurrency.yaml

@@ -21,5 +21,7 @@ Resources:
       Runtime: python2.7
       DeploymentPreference:
         Type: Linear10PercentEvery3Minutes
-      ProvisionedConcurrencyConfig:
-        ProvisionedConcurrentExecutions: !If [AliasProvisionedConcurrencyEnabled, ProvisionedConcurrentExecutions: !Ref ProvisionedConcurrency, !Ref 'AWS::NoValue']
+      ProvisionedConcurrencyConfig: !If
+        - AliasProvisionedConcurrencyEnabled
+        - ProvisionedConcurrentExecutions: !Ref ProvisionedConcurrency
+        - !Ref 'AWS::NoValue'

tests/translator/input/function_with_deployment_preference.yaml

@@ -22,5 +22,7 @@ Resources:
       AutoPublishAlias: live
       DeploymentPreference:
         Type: Linear10PercentEvery3Minutes
-      ProvisionedConcurrencyConfig:
-        ProvisionedConcurrentExecutions: !If [AliasProvisionedConcurrencyEnabled, !Ref ProvisionedConcurrency, !Ref 'AWS::NoValue']
+      ProvisionedConcurrencyConfig: !If
+        - AliasProvisionedConcurrencyEnabled
+        - ProvisionedConcurrentExecutions: !Ref ProvisionedConcurrency
+        - !Ref 'AWS::NoValue'

tests/translator/output/aws-cn/function_with_deployment_preference.json

@@ -174,18 +174,18 @@
           ]
         }, 
         "ProvisionedConcurrencyConfig": {
-          "ProvisionedConcurrentExecutions": {
-            "Fn::If": [
-              "AliasProvisionedConcurrencyEnabled", 
-              {
+          "Fn::If": [
+            "AliasProvisionedConcurrencyEnabled",
+            {
+              "ProvisionedConcurrentExecutions": {
                 "Ref": "ProvisionedConcurrency"
-              }, 
-              {
-                "Ref": "AWS::NoValue"
               }
-            ]
-          }
-        }, 
+            },
+            {
+              "Ref": "AWS::NoValue"
+            }
+          ]
+        },
         "FunctionName": {
           "Ref": "MinimalFunction"
         }

tests/translator/output/aws-us-gov/function_with_deployment_preference.json

@@ -174,18 +174,18 @@
           ]
         }, 
         "ProvisionedConcurrencyConfig": {
-          "ProvisionedConcurrentExecutions": {
-            "Fn::If": [
-              "AliasProvisionedConcurrencyEnabled", 
-              {
+          "Fn::If": [
+            "AliasProvisionedConcurrencyEnabled",
+            {
+              "ProvisionedConcurrentExecutions": {
                 "Ref": "ProvisionedConcurrency"
-              }, 
-              {
-                "Ref": "AWS::NoValue"
               }
-            ]
-          }
-        }, 
+            },
+            {
+              "Ref": "AWS::NoValue"
+            }
+          ]
+        },
         "FunctionName": {
           "Ref": "MinimalFunction"
         }

tests/translator/output/function_with_deployment_preference.json

@@ -174,18 +174,18 @@
           ]
         }, 
         "ProvisionedConcurrencyConfig": {
-          "ProvisionedConcurrentExecutions": {
-            "Fn::If": [
-              "AliasProvisionedConcurrencyEnabled", 
-              {
+          "Fn::If": [
+            "AliasProvisionedConcurrencyEnabled",
+            {
+              "ProvisionedConcurrentExecutions": {
                 "Ref": "ProvisionedConcurrency"
-              }, 
-              {
-                "Ref": "AWS::NoValue"
               }
-            ]
-          }
-        }, 
+            },
+            {
+              "Ref": "AWS::NoValue"
+            }
+          ]
+        },
         "FunctionName": {
           "Ref": "MinimalFunction"
         }