Skip to content

feat(bedrockconstruct): added support for IAM existingRole #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 22, 2024

Conversation

dineshSajwan
Copy link
Contributor

Fixes #

  1. Added existingRole prop in agent and knowledgebase construct . If existingRole is provided then the construct don't create I am policy for Agent and knowledgebase.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Signed-off-by: github-actions <[email protected]>
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 97.75281% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.05%. Comparing base (b34f4e9) to head (4204495).

Files Patch % Lines
src/cdk-lib/bedrock/agent.ts 97.77% 1 Missing ⚠️
src/cdk-lib/bedrock/knowledge-base.ts 97.72% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
- Coverage   93.26%   93.05%   -0.21%     
==========================================
  Files          47       47              
  Lines       11224    11247      +23     
  Branches      364      366       +2     
==========================================
- Hits        10468    10466       -2     
- Misses        756      781      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

krokoko
krokoko previously approved these changes May 16, 2024
Copy link
Collaborator

@krokoko krokoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, was this tested properly ?

@dineshSajwan dineshSajwan changed the title Feat/bedrock existing role feat(bedrockconstruct): added support for IAM existingRole May 21, 2024
Signed-off-by: github-actions <[email protected]>
@krokoko krokoko self-requested a review May 21, 2024 19:30
@anitalewis anitalewis self-requested a review May 22, 2024 14:36
Copy link
Member

@anitalewis anitalewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krokoko krokoko merged commit a8d4373 into main May 22, 2024
@krokoko krokoko deleted the feat/bedrock_existing_role branch May 22, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants