-
Notifications
You must be signed in to change notification settings - Fork 67
feat(bedrockconstruct): added support for IAM existingRole #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: github-actions <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
==========================================
- Coverage 93.26% 93.05% -0.21%
==========================================
Files 47 47
Lines 11224 11247 +23
Branches 364 366 +2
==========================================
- Hits 10468 10466 -2
- Misses 756 781 +25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, was this tested properly ?
Signed-off-by: Dinesh Sajwan <[email protected]>
Signed-off-by: github-actions <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.