LambdaToDynamoDB doesn't allow pointInTimeReoverySpecification only

[vicentenoriega]

When using LambdaToDynamoDB by passing dynamoTableProps with pointInTimeRecoverySpecification and not pointInTimeRecovery error is thrown.

Reproduction Steps

new LambdaToDynamoDB(this, 'my-dynamo', {
      existingLambdaObj: myLambdaObj,
      tableEnvironmentVariableName: 'DDB_TABLE_NAME',
      dynamoTableProps: {
        partitionKey: { name: 'myPartitionKey', type: AttributeType.STRING },
        sortKey: { name: 'mySortKey', type: AttributeType.NUMBER },
        tableName: my-table-name,
        removalPolicy: RemovalPolicy.Retain,
        deletionProtection: true,
        encryption: TableEncryption.AWS_MANAGED,
        pointInTimeRecoverySpecification: {
           pointInTimeRecoveryEnabled:  true
        },
        billingMode: BillingMode.PAY_PER_REQUEST,
      },
    });

Error Log

ValidationError: pointInTimeRecoverySpecification and pointInTimeRecovery are set. Use pointInTimeRecoverySpecification only. at path [my-stack-path] in aws-cdk-lib.aws_dynamodb.Table

Environment

• CDK CLI Version :
• CDK Framework Version: 2.195.0
• AWS Solutions Constructs Version : 2.86.0
• OS :
• Language : TypeScript

Other

By adding pointInTimeRecovery: undefined everything looks working fine.

new LambdaToDynamoDB(this, 'my-dynamo', {
      existingLambdaObj: myLambdaObj,
      tableEnvironmentVariableName: 'DDB_TABLE_NAME',
      dynamoTableProps: {
        partitionKey: { name: 'myPartitionKey', type: AttributeType.STRING },
        sortKey: { name: 'mySortKey', type: AttributeType.NUMBER },
        tableName: my-table-name,
        removalPolicy: RemovalPolicy.Retain,
        deletionProtection: true,
        encryption: TableEncryption.AWS_MANAGED,
        pointInTimeRecovery: undefined,
        pointInTimeRecoverySpecification: {
           pointInTimeRecoveryEnabled:  true
        },
        billingMode: BillingMode.PAY_PER_REQUEST,
      },
    });

It looks like somewhere pointInTimeRecovery is being set by default if it's not part of the dynamoTableProps and since we send pointInTimeRecoverySpecification, both properties are added so the validation error is thrown.

#1300
#1301
#1328 (I added a few comments after a quick look at the code)

Sorry in advance if there is not enough information I'm new user of aws-solutions-constructs. Let me know if you need any more information :)

---

This is 🐛 Bug Report

[biffgaut]

Thanks for using Constructs - glad to have you as a user!

We'll take a look at this.

[biffgaut]

I'm getting stuck on the line in your example:

      'DDB_TABLE_NAME',

Is this a typo? I don't see how it can fit into the Props object

[vicentenoriega]

I'm getting stuck on the line in your example:

      'DDB_TABLE_NAME',

Is this a typo? I don't see how it can fit into the Props object

Yes, I edited the original post and it's correct now.

[biffgaut]

I'm not abled to reproduce the behavior you're showing with the versions of Constructs you list. When I launch with v2.86.0 everything works fine.

PR #1301 addressed this error, when I go back to v2.82.0 (the release before PR #1301 was published) I can reproduce this behavior. Are you certain that you are using v2.86.0 of LambdaToDynamoDB?

[vicentenoriega]

I'm not abled to reproduce the behavior you're showing with the versions of Constructs you list. When I launch with v2.86.0 everything works fine.

PR #1301 addressed this error, when I go back to v2.82.0 (the release before PR #1301 was published) I can reproduce this behavior. Are you certain that you are using v2.86.0 of LambdaToDynamoDB?

My bad! I was using 2.86.0 of aws-lamda-dynamodb but 2.72 of core... Sorry for the incovenience.

Anyways I think some of the comments I left at #1328 could be good improvements.

Thanks for having a look @biffgaut. Keep up the great work :)

[biffgaut]

Glad you've got it working. Word of warning - keep all your Constructs modules on the same version, I really don't know what kind of chaos will erupt if there are different versions of the modules interacting in one app.