Make errors implement Debug+Display #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::error::Error has the minimal requirement of describing errors with both of these traits, I think we should enforce it too. This will allow us to send the full callstack to CloudWatch when there is an error. Signed-off-by: David Calavera <[email protected]>
2 tasks
nmoutschen
approved these changes
Feb 17, 2022
2 tasks
|
Nice! Now looking forward to a new release. It's been a while since the last one. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::error::Error has the minimal requirement of describing
errors with both of these traits, I think we should enforce it too.
This will allow us to send the full callstack to CloudWatch when
there is an error.
Fixes #348
Signed-off-by: David Calavera [email protected]
By submitting this pull request