Log error chain to CloudWatch Logs #413
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlafeldt
force-pushed
the
cloudwatch-error-chain
branch
from
e8ea944 to
cd89e7d
Compare
The anyhow crate will only include the error chain with {:?} or {:#}.
Without this change, only the last error will be logged to CloudWatch
and all underlying causes are lost when using with_context to augment
errors.
Fixes aws#348
mlafeldt
force-pushed
the
cloudwatch-error-chain
branch
from
cd89e7d to
018b2cf
Compare
mlafeldt
changed the title
calavera
approved these changes
Feb 9, 2022
calavera
suggested changes
Feb 9, 2022
Contributor
calavera
left a comment
calavera
left a comment
There was a problem hiding this comment.
It looks like this change is not as simple as we thought. There are errors now because some traits need to implement the Debug trait 😔
Contributor
|
I've addressed the build errors in #418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The anyhow crate will only include the error chain with
{:?}or{:#}.Without this change, only the last error will be logged to CloudWatch and all underlying causes are lost when using
with_contextto augment errors.Fixes #348
By submitting this pull request