Skip to content

Allow base paths in the runtime api uri #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

calavera
Copy link
Contributor

@calavera calavera commented Jan 7, 2022

Signed-off-by: David Calavera [email protected]

Issue #, if available:

Fixes #390

Description of changes:

This change allows to set the runtime api location with a base path.
This helps tools outside production to set their own full locations
that might not be in the root of the uri.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

This change allows to set the runtime api location with a base path.
This helps tools outside production to set their own full locations
that might not be in the root of the uri.

Signed-off-by: David Calavera <[email protected]>
Copy link
Contributor

@nmoutschen nmoutschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nmoutschen nmoutschen merged commit 7b2c48a into awslabs:master Jan 7, 2022
@calavera calavera deleted the allow_base_origin_paths branch January 7, 2022 17:42
@nmoutschen nmoutschen added the 0.5 label Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow any path parts in AWS_LAMBDA_RUNTIME_API to remain intact
2 participants