Making Error type public so that consumers don't have to create their own type alias #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You beat me to the punch by minutes! |
|
@bahildebrand My bad I should have marked this one as assigned! |
lambda-runtime/examples/basic.rs
Outdated
| @@ -29,7 +25,7 @@ struct Response { | |||
| } | |||
|
|
|||
| #[tokio::main] | |||
| async fn main() -> Result<(), Error> { | |||
| async fn main() -> Result<(), lambda_runtime::Error> { | |||
There was a problem hiding this comment.
Can we include the error type instead? Same for the other examples as well.
There was a problem hiding this comment.
Ah yeah I totally agree, I think it would look better as an include. Let me address that and push the change up.
All good haha! It wasn't a large change, so not much time was spent on it. |
bahildebrand
approved these changes
Mar 12, 2021
rimutaka
approved these changes
Mar 12, 2021
… in imports instead.
I agree with your comment! Just pushed a commit up with that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #297
Description of changes: The
Errortype alias was formerly public only to the lambda_runtime crate. Made this public and replace customer type aliases elsewhere.By submitting this pull request