Add note to README.md build for Mac OS #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you follow the directions here on Mac OS you get the following error:
```
= note: clang: warning: argument unused during compilation: '-static-pie' [-Wunused-command-line-argument]
ld: unknown option: --as-needed
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
Following the steps [here](https://aws.amazon.com/blogs/opensource/rust-runtime-for-aws-lambda/) resolved the issue for me, which was basically just installing and using the linker from filosottile/musl-cross/musl-cross.
coltonweaver
suggested changes
Jan 19, 2021
README.md
Outdated
| @@ -64,6 +64,14 @@ Run this script once to add the new target: | |||
| $ rustup target add x86_64-unknown-linux-musl | |||
| ``` | |||
|
|
|||
|
|
|||
| * **Note:** If you are running on Mac OS you'll need to install the linker for the target platform. You do this using the `musl-cross` tap from [Homebrew](https://brew.sh/) which provides a complete cross-compilation toolchain for Mac OS. Once `musl-cross` is installed we will also need to inform cargo of the newely installed linker when building for the `x86_64-unknown-linux-musl` platform. | |||
README.md
Outdated
Comment on lines
70
to
72
| $ brew install filosottile/musl-cross/musl-cross | ||
| $ mkdir .cargo | ||
| $ echo $'[target.x86_64-unknown-linux-musl]\nlinker = "x86_64-linux-musl-gcc"' > .cargo/config |
There was a problem hiding this comment.
For consistency can we remove the additional whitespace in front of each command?
|
Perhaps linking to https://aws.amazon.com/blogs/opensource/rust-runtime-for-aws-lambda/ would be helpful as well, as it has even more information. |
|
I decided to address the nit comments to unblock this, and I've decided that adding that link isn't worthwhile. |
coltonweaver
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you follow the directions here on Mac OS you get the following error:
Following the steps here resolved the issue for me, which was basically just installing and using the linker from filosottile/musl-cross/musl-cross.
Issue #, if available:
Description of changes:
By submitting this pull request