PHP: Update CloudFront signing URL examples to a supported API version #5435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stobrien89
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Thanks for the assist on this @wsamoht. I'm making a change in our repository to prevent this api version from being used at client initialization.
rlhagerm
approved these changes
Oct 3, 2023
rlhagerm
requested changes
Oct 3, 2023
|
I think the linting is out of scope for these changes, and will be covered by an upcoming project anyway, so I'll override the linting errors. |
rlhagerm
approved these changes
Oct 3, 2023
rlhagerm
added
On Call Review complete
ford-at-aws
pushed a commit
that referenced
this pull request
Dec 15, 2023
#5435) Update CloudFront signing URL examples to a supported API version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in
aws/aws-sdk-phpversion 3.281.13, CloudFront API version2014-11-06stopped working. It is also no longer on the supported version list here.I've updated the version to
2018-06-18to a working version and to bring it inline with the other non-URL signing examples.Some more details can be found in the discussion I created here.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.