Skip to content

fix: do not log InvalidDocumentException as an uncaught error #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2019
Merged

fix: do not log InvalidDocumentException as an uncaught error #973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions samtranslator/plugins/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import logging

from samtranslator.model.exceptions import InvalidResourceException
from samtranslator.model.exceptions import InvalidResourceException, InvalidDocumentException
from enum import Enum


Expand Down Expand Up @@ -128,7 +128,7 @@ def act(self, event, *args, **kwargs):

try:
getattr(plugin, method_name)(*args, **kwargs)
except InvalidResourceException as ex:
except (InvalidResourceException, InvalidDocumentException) as ex:
# Don't need to log these because they don't result in crashes
raise ex
except Exception as ex:
Expand Down