Skip to content

Conversation

jadhavmanoj
Copy link
Contributor

Issue #891, if available:

Description of changes:
Added test cases for semantic version check (if provided as None/Empty)

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Manoj Jadhav and others added 30 commits April 28, 2019 18:40
@jadhavmanoj jadhavmanoj changed the title Fix/semanticversion Added test cases for semantic version check May 20, 2019
@codecov-io
Copy link

codecov-io commented May 20, 2019

Codecov Report

Merging #929 into develop will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #929      +/-   ##
===========================================
+ Coverage    94.66%   94.73%   +0.06%     
===========================================
  Files           69       69              
  Lines         3018     3018              
  Branches       562      562              
===========================================
+ Hits          2857     2859       +2     
+ Misses          85       84       -1     
+ Partials        76       75       -1
Impacted Files Coverage Δ
...lator/plugins/application/serverless_app_plugin.py 83.44% <0%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7a4e6...5c6e6c6. Read the comment docs.

Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@keetonian keetonian requested a review from praneetap May 20, 2019 21:36
@praneetap praneetap merged commit 31cc0f9 into aws:develop May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants