Skip to content

Noting "httpMethod" attribute is for lambda call #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Noting "httpMethod" attribute is for lambda call #875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/2016-10-31/api_swagger_cors/swagger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ paths:
Fn::Sub: "arn:aws:apigateway:${AWS::Region}:lambda:path/2015-03-31/functions/${LambdaFunction.Arn}/invocations"

passthroughBehavior: when_no_match
httpMethod: POST
httpMethod: POST # Keep "POST" when the API definition method is not POST. This "httpMethod" is used to call Lambda.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying this. I've definitely been bitten by this as well. 😅

Consider adding a link to the API Gateway documentation in case someone wants to learn more: https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-swagger-extensions-integration.html

type: aws_proxy
/{proxy+}:
x-amazon-apigateway-any-method:
Expand All @@ -41,7 +41,7 @@ paths:
x-amazon-apigateway-integration:
uri:
Fn::Sub: "arn:aws:apigateway:${AWS::Region}:lambda:path/2015-03-31/functions/${LambdaFunction.Arn}/invocations"
httpMethod: POST
httpMethod: POST # Keep "POST" when the API definition method is not POST. This "httpMethod" is used to call Lambda.
type: aws_proxy
definitions:
Empty:
Expand Down