refactor: move methods that modify parameter values to a separate class #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #862 +/- ##
===========================================
- Coverage 94.68% 94.66% -0.03%
===========================================
Files 67 69 +2
Lines 2975 2978 +3
Branches 547 547
===========================================
+ Hits 2817 2819 +2
- Misses 83 84 +1
Partials 75 75
Continue to review full report at Codecov.
|
brettstack
changed the title
brettstack
reviewed
Mar 21, 2019
| sam_parameter_values.add_default_parameter_values(sam_template) | ||
| self.assertEqual(expected, sam_parameter_values.parameter_values) | ||
|
|
||
| def test_add_default_parameter_values_must_skip_params_without_defaults(self): |
There was a problem hiding this comment.
This would fail CFN execution, right? All Params require a value. Can (should) we fail early? I like the idea of SAM failing faster than CFN when possible. Then again, it could be possible that a Plugin could fill in Params, but I can't think of a use-case. I'd like to get James and Keeton's feedback too.
| param(None) | ||
| ]) | ||
| def test_add_default_parameter_values_must_ignore_invalid_template_parameters(self, template_parameters): |
There was a problem hiding this comment.
Again, if they're invalid can we fail early?
brettstack
approved these changes
Mar 21, 2019
keetonian
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Move methods that modify parameter values to a separate class
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.