Skip to content

Conversation

honglu
Copy link
Contributor

@honglu honglu commented Mar 15, 2019

Description of changes:
Support Ref: 'AWS::Region'

Description of how you validated changes:
Added unit tests and end-to-end tests

Checklist:

  • Write/update tests
  • make pr passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@honglu honglu requested review from keetonian and brettstack March 15, 2019 00:02
@codecov-io
Copy link

Codecov Report

Merging #855 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #855      +/-   ##
===========================================
+ Coverage    94.56%   94.57%   +<.01%     
===========================================
  Files           67       67              
  Lines         2834     2839       +5     
  Branches       508      509       +1     
===========================================
+ Hits          2680     2685       +5     
  Misses          82       82              
  Partials        72       72
Impacted Files Coverage Δ
samtranslator/intrinsics/actions.py 98.58% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4339ff1...4963cc5. Read the comment docs.

@honglu honglu requested a review from jlhood March 15, 2019 17:43
Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for adding this!

@brettstack brettstack merged commit 22affd6 into aws:develop Mar 15, 2019
@honglu honglu deleted the ref-region branch March 19, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants