Skip to content

Conversation

sblask
Copy link
Contributor

@sblask sblask commented Feb 6, 2019

CodeUri in Globals seems to be supported by at least sam-cli 0.6.1, making the comment about it being unsupported obsolete.

Description of changes:
Remove comment about CodeUri being unsupported in Globals

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

CodeUri in Globals seems to be supported by at least sam-cli 0.6.1, making the comment about it being unsupported obsolete.
@codecov-io
Copy link

Codecov Report

Merging #795 into master will decrease coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
- Coverage   94.85%   94.32%   -0.54%     
==========================================
  Files          67       67              
  Lines        3772     2626    -1146     
  Branches      828      464     -364     
==========================================
- Hits         3578     2477    -1101     
+ Misses         97       78      -19     
+ Partials       97       71      -26
Impacted Files Coverage Δ
samtranslator/yaml_helper.py 80% <0%> (-8.89%) ⬇️
samtranslator/model/s3_utils/uri_parser.py 71.42% <0%> (-6.35%) ⬇️
samtranslator/model/eventsources/push.py 86.59% <0%> (-3.01%) ⬇️
samtranslator/model/eventsources/pull.py 91.48% <0%> (-2.8%) ⬇️
...el/preferences/deployment_preference_collection.py 88.88% <0%> (-2.78%) ⬇️
samtranslator/translator/arn_generator.py 86.95% <0%> (-1.94%) ⬇️
samtranslator/model/intrinsics.py 95% <0%> (-1.78%) ⬇️
samtranslator/swagger/swagger.py 97.84% <0%> (-0.74%) ⬇️
samtranslator/model/api/api_generator.py 95.9% <0%> (-0.66%) ⬇️
samtranslator/translator/logical_id_generator.py 90% <0%> (-0.48%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16988e4...71dc164. Read the comment docs.

@keetonian keetonian changed the base branch from master to develop February 6, 2019 20:08
Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@keetonian keetonian merged commit 3ef6b7d into aws:develop Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants