Add support for Permissions Boundary on Function #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #782 +/- ##
===========================================
- Coverage 94.71% 94.22% -0.49%
===========================================
Files 67 67
Lines 2950 2686 -264
Branches 578 478 -100
===========================================
- Hits 2794 2531 -263
- Misses 78 80 +2
+ Partials 78 75 -3
Continue to review full report at Codecov.
|
brettstack
reviewed
Jan 25, 2019
There was a problem hiding this comment.
This is great! For Globals, check out this PR which added Auth to Globals https://github.com/awslabs/serverless-application-model/pull/682/files
brettstack
approved these changes
Jan 25, 2019
|
Updated with globals support. Cheers! |
keetonian
reviewed
Jan 31, 2019
| tox>=2.2.1 | ||
| pytest-cov>=2.4.0 | ||
| pylint>=1.7.2 | ||
| pylint>=1.7.2,<2.0 |
There was a problem hiding this comment.
Any particular reason why this was necessary?
There was a problem hiding this comment.
pip was trying to install a post 2.0 version which required py3.
keetonian
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#661
Description of changes:
Adds support for specifying permissions boundary on a serverless function. Includes test templates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.