feat: add support for Conditions in Serverless API #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/v1.10.0 #742 +/- ##
===================================================
+ Coverage 94.18% 94.18% +<.01%
===================================================
Files 67 67
Lines 2683 2685 +2
Branches 478 478
===================================================
+ Hits 2527 2529 +2
Misses 80 80
Partials 76 76
Continue to review full report at Codecov.
|
|
Could you add a nontrivial condition test case and confirm it works as expected ? For all the cases I see here, both options are |
|
Just curious, what's the use of these output files? |
paoptu023
reviewed
Jan 2, 2019
| definition_body, definition_uri, name, stage_name, endpoint_configuration=None, | ||
| method_settings=None, binary_media=None, cors=None, auth=None, access_log_setting=None, | ||
| canary_setting=None, tracing_enabled=None): | ||
| canary_setting=None, tracing_enabled=None, resource_attributes=None, |
There was a problem hiding this comment.
Can you add definitions for the newly added params in function docstring?
Contributor
Author
There was a problem hiding this comment.
Good catch. Will add
Contributor
Author
|
paoptu023
approved these changes
Jan 2, 2019
mlaff
approved these changes
Jan 2, 2019
keetonian
added a commit
to keetonian/serverless-application-model
that referenced
this pull request
Feb 14, 2019
This reverts commit ffb3e35.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#142
Description of changes:
Add support for Conditions in Serverless API
Similar to #707 and #653
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.