fix: layer logical ids now change when referenced parameters change #709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #709 +/- ##
===========================================
+ Coverage 94.17% 94.19% +0.01%
===========================================
Files 67 67
Lines 2678 2686 +8
Branches 478 478
===========================================
+ Hits 2522 2530 +8
Misses 80 80
Partials 76 76
Continue to review full report at Codecov.
|
keetonian
force-pushed
the
layer-version-logical-id
branch
from
452665b to
47251da
Compare
keetonian
force-pushed
the
layer-version-logical-id
branch
from
47251da to
f884617
Compare
|
Note: this change does not resolve intrinsics for ContentUri or for CompatibleRuntimes. Should I add these to this PR as well? |
keetonian
changed the title
paoptu023
approved these changes
Dec 10, 2018
jlhood
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#703
Description of changes:
Support reading intrinsics in LayerName, LicenseInfo, and Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.