Skip to content

fix: add missing parameter to s3 bucket resource #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2018
Merged

fix: add missing parameter to s3 bucket resource #700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0ee765
fix: add missing parameter to s3 bucket resource
keetonian Dec 3, 2018
ae63f39
add PublicAccessBlockConfiguration to tests to ensure it works for s3…
keetonian Dec 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions samtranslator/model/s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ class S3Bucket(Resource):
'LoggingConfiguration': PropertyType(False, any_type()),
'MetricsConfigurations': PropertyType(False, any_type()),
'NotificationConfiguration': PropertyType(False, is_type(dict)),
'PublicAccessBlockConfiguration': PropertyType(False, is_type(dict)),
'ReplicationConfiguration': PropertyType(False, any_type()),
'Tags': PropertyType(False, is_type(list)),
'VersioningConfiguration': PropertyType(False, any_type()),
Expand Down
6 changes: 6 additions & 0 deletions tests/translator/input/s3_multiple_functions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,9 @@ Resources:

Images:
Type: AWS::S3::Bucket
Properties:
PublicAccessBlockConfiguration:
BlockPublicAcls: true
BlockPublicPolicy: true
IgnorePublicAcls: true
RestrictPublicBuckets: true
6 changes: 6 additions & 0 deletions tests/translator/output/aws-cn/s3_multiple_functions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@
"Event": "s3:ObjectCreated:*"
}
]
},
"PublicAccessBlockConfiguration": {
"BlockPublicAcls": true,
"BlockPublicPolicy": true,
"IgnorePublicAcls": true,
"RestrictPublicBuckets": true
}
},
"DependsOn": [
Expand Down
6 changes: 6 additions & 0 deletions tests/translator/output/aws-us-gov/s3_multiple_functions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@
"Event": "s3:ObjectCreated:*"
}
]
},
"PublicAccessBlockConfiguration": {
"BlockPublicAcls": true,
"BlockPublicPolicy": true,
"IgnorePublicAcls": true,
"RestrictPublicBuckets": true
}
},
"DependsOn": [
Expand Down
6 changes: 6 additions & 0 deletions tests/translator/output/s3_multiple_functions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@
"Event": "s3:ObjectCreated:*"
}
]
},
"PublicAccessBlockConfiguration": {
"BlockPublicAcls": true,
"BlockPublicPolicy": true,
"IgnorePublicAcls": true,
"RestrictPublicBuckets": true
}
},
"DependsOn": [
Expand Down