Feature/sns filter policy #648
Merged
+462
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to align with the order in the original SAM template.
|
This is great! We'll take a look; in the meantime do you think you could add an example? You can check out this example as a good example of an example https://github.com/awslabs/serverless-application-model/tree/master/examples/2016-10-31/api_lambda_request_auth :) |
|
Very useful! Would love to see this one get merged. |
|
Ready to merge? Thanks |
brettstack
approved these changes
Nov 13, 2018
jlhood
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #261 :
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.