Skip to content

Conversation

hcanalesmx
Copy link
Contributor

…t within a Collection in AWS Rekognition

Issue #, if available:

Description of changes:
Hello. I am adding the "RekognitionFacesManagementPolicy" template policy since I need the rekognition:DeleteFaces permission for an application that I want to publish in the repository.

I think a template like this could cover the most user cases when managing faces.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@keetonian
Copy link
Contributor

Hi! In my initial look through this template, the scoping of resources as well as the policy actions you've defined look appropriate. Could you also add this policy to the tests like was done in https://github.com/awslabs/serverless-application-model/pull/586/files? Thanks!

@hcanalesmx
Copy link
Contributor Author

Done! 👍

Copy link
Contributor

@keetonian keetonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I'm still waiting on the Travis check to complete, but this looks good!

@hcanalesmx
Copy link
Contributor Author

Any idea if there is a release planned this week that would include this template? I am asking because I would like to publish for the devPost Hackaton. Thank you!

@brettstack brettstack merged commit 93d8b1c into aws:develop Sep 25, 2018
@brettstack
Copy link
Contributor

@HCans I can't comment on dates, but we'll get this into the 1.8.0 release keeping in mind that this is for the hackathon.

@keetonian
Copy link
Contributor

This feature has now been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants