Skip to content

Conversation

davfaulk
Copy link
Contributor

@davfaulk davfaulk commented May 8, 2018

… (ce:* and Organizations:ListAccounts), that cannot be resource scoped, useful for using lambda for cost reporting. Also added SendRawEmail to existing SESCrudPolicy

Issue #, if available:

Description of changes:
Two new read-only policy templates to support adding https://github.com/aws-samples/aws-cost-explorer-report to the Serverless Application Repository. API calls do not support resource downscoping due to nature of calls.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

brettstack
brettstack previously approved these changes May 22, 2018
@brettstack brettstack self-assigned this May 22, 2018
Copy link
Contributor

@brettstack brettstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just doc updates. Can you apply these changes to the other files necessary? You can follow this PR for example https://github.com/awslabs/serverless-application-model/pull/408/files

@brettstack
Copy link
Contributor

@davfaulk did you want to fix this?

@davfaulk
Copy link
Contributor Author

Apologies for the delay - been traveling etc. Modified the other files, and ran tests.

@jlhood
Copy link
Contributor

jlhood commented Sep 1, 2018

Sorry for the delayed response on this. We have since removed the redundant docs/policy_templates_data/policy_templates.json file so now the only file to modify is samtranslator/policy_templates_data/policy_templates.json Can you merge the latest develop branch, resolve conflicts and update this PR?

@brettstack
Copy link
Contributor

Thanks @davfaulk, could you rebase this on latest develop branch? As James mentioned, we removed redundant file which is the main cause for this conflict.

@davfaulk
Copy link
Contributor Author

Rebased off of current develop

@brettstack brettstack merged commit 9a44d23 into aws:develop Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants