fix: allow minor version upgrades of dependencies #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow minor version upgrades for package requirements According to [PEP440](https://www.python.org/dev/peps/pep-0440/#compatible-release), `~=` operator will do setup a prefix matching of the last version number. So `pkg~=1.1.0` will allow only patch version upgrades, while `pkg~=1.1` will allow all minor version upgrades while preventing major version changes ie. 2.x This was my intention with an earlier commit but unfortunately I missed the fine print in PEP440. This is especially important for boto3 because of how often they release. Users that have any version of v1.5<=boto3<v2.0 should be compatible with SAM Translator. SAM Translator uses boto3 only to query the default region configured in their shell. Being compatible with patch and minor versions allows SAM Translator to be installable in computers that have any relatively recent (> Dec 2017) version of AWS CLI. Without this change, SAM Translator cannot be run on computers with a more recent version of AWS CLI installation that bundles a recent version of boto3. This is a good practice in general to allow for easy deployment of security changes as recommended by [PEP404](https://www.python.org/dev/peps/pep-0440/#version-matching) * Bumping to v1.5.4 to prep for release
jfuss
approved these changes
May 3, 2018
brettstack
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.5.4