perf: use list join instead of string concatenation in loop #3829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reedham-aws
requested changes
Oct 16, 2025
Comment on lines
101
to
104
| # OLD APPROACH: String concatenation in loop | ||
| # self.function_names.setdefault(api_name, "") | ||
| # self.function_names[api_name] += str(resolved_function_name) | ||
| # NEW APPROACH: Collect in list |
There was a problem hiding this comment.
I don't think we need the comment with the old approach.
Comment on lines
136
to
137
| # OLD: self.function_names: Dict[Any, Any] = {} | ||
| # NEW: Use List[str] for efficient accumulation, convert to str when needed |
There was a problem hiding this comment.
Same suggestion on commenting the old approach.
Comment on lines
105
to
106
| if api_name not in self.function_names: | ||
| self.function_names[api_name]=[] |
There was a problem hiding this comment.
Suggested change
| if api_name not in self.function_names: | |
| self.function_names[api_name]=[] | |
| self.function_names.setdefault(api_name, []) |
| if api_name not in self.function_names: | ||
| self.function_names[api_name]=[] | ||
| self.function_names[api_name].append(str(resolved_function_name)) | ||
| #backward compatibility |
There was a problem hiding this comment.
Comment is also probably unnecessary.
reedham-aws
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
N/A - Performance optimization proposal
Description of changes
Replace O(n^2) string concatenation with O(n) list accumulation in
_get_function_names()method.Current approach: Uses
+=operator in loop, creating new string objects on each iterationProposed approach: Accumulate in list, join at end using
''.join()This maintains backward compatibility.
Description of how you validated changes
Dict[str, List[str]])Checklist
Examples?
N/A - Internal performance optimization
Note: This is not a critical fix...
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.