Skip to content

Conversation

hoffa
Copy link
Contributor

@hoffa hoffa commented Dec 13, 2022

Issue #, if available

Description of changes

  • No need to test intrinsic functions; per the development guidelines we longer do it explicitly. Instead AWS::LanguageExtensions resolves them beforehand.
  • Verifying the transformed template deploys and works as expected is the integration test.
  • Documentation changes are done once the transform is deployed.
  • The last check (or, 3 nested checks) is a good intention about not breaking backward compatibility (in development guidelines), but it's verbose and confusing in its current state.

Description of how you validated changes

Checklist

Examples?

Please reach out in the comments if you want to add an example. Examples will be
added to sam init through aws/aws-sam-cli-app-templates.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hoffa hoffa changed the title Update PULL_REQUEST_TEMPLATE.md docs: clean up PR checklist Dec 13, 2022
Copy link
Contributor

@acristin acristin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@hoffa hoffa marked this pull request as ready for review December 13, 2022 01:21
@hoffa hoffa requested a review from a team as a code owner December 13, 2022 01:21
@hoffa hoffa merged commit 6c83ab6 into develop Dec 13, 2022
@hoffa hoffa deleted the hoffa-patch-1 branch December 13, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants