Skip to content

Conversation

qingchm
Copy link
Contributor

@qingchm qingchm commented Sep 23, 2022

Issue #, if available:
N.A.

Description of changes:
In the integration test logging, when tests are running in parallel, the position of the logging messages does not follow the exact test it belongs to. Therefore a header is added to indicate the test case each request belongs to.

Description of how you validated changes:
Ran locally to see the logs:
REQUEST LOG [test_cors_1_combination_api_with_cors_openapi] | Time: 2022-09-22 22:28:08,487 Request made to https://* | Status: 200 | Headers: {*}

Checklist:

  • Add/update unit tests using:
  • Add/update integration tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Merging #2513 (05bd853) into develop (e7a1496) will increase coverage by 0.92%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2513      +/-   ##
===========================================
+ Coverage    93.58%   94.51%   +0.92%     
===========================================
  Files           90       97       +7     
  Lines         6124     7307    +1183     
  Branches      1260     1526     +266     
===========================================
+ Hits          5731     6906    +1175     
- Misses         183      193      +10     
+ Partials       210      208       -2     
Impacted Files Coverage Δ
samtranslator/region_configuration.py 77.77% <0.00%> (-22.23%) ⬇️
samtranslator/model/codedeploy.py 90.90% <0.00%> (-9.10%) ⬇️
samtranslator/validator/validator.py 91.80% <0.00%> (-3.85%) ⬇️
samtranslator/model/exceptions.py 97.67% <0.00%> (-2.33%) ⬇️
samtranslator/open_api/open_api.py 90.16% <0.00%> (-1.81%) ⬇️
samtranslator/model/s3_utils/uri_parser.py 68.42% <0.00%> (-0.81%) ⬇️
samtranslator/yaml_helper.py 89.47% <0.00%> (-0.53%) ⬇️
samtranslator/translator/logical_id_generator.py 90.62% <0.00%> (-0.29%) ⬇️
samtranslator/model/apigateway.py 96.98% <0.00%> (-0.18%) ⬇️
samtranslator/intrinsics/resource_refs.py 95.83% <0.00%> (-0.17%) ⬇️
... and 50 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qingchm qingchm merged commit 2acbc24 into aws:develop Sep 23, 2022
boldfrog1805 pushed a commit to boldfrog1805/serverless-application-model that referenced this pull request Oct 7, 2022
…m pytest.ini (aws#2513)

* Add test name to request logging, remove default region from pytest.ini

* Add aws default region for running unit tests
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Oct 7, 2022
* Update check() and checkdepends following
  aws/serverless-application-model#2513
* Add transitive deps detected by patched namcap


git-svn-id: file:///srv/repos/svn-community/svn@1323810 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Oct 7, 2022
* Update check() and checkdepends following
  aws/serverless-application-model#2513
* Add transitive deps detected by patched namcap

git-svn-id: file:///srv/repos/svn-community/svn@1323810 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants