Skip to content

Conversation

nallenscott
Copy link
Contributor

Issue #, if available:

N/A

Description of changes:

Add state property to EventBridgeRule EventSource for AWS::Serverless::Function.

Description of how you validated changes:

Added invalid input and transform tests.

Checklist:

  • Add/update unit tests using:
  • Add/update integration tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Sep 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (e7a1496) to head (a107f8c).
Report is 1099 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2497      +/-   ##
===========================================
+ Coverage    93.58%   94.51%   +0.92%     
===========================================
  Files           90       97       +7     
  Lines         6124     7307    +1183     
  Branches      1260     1526     +266     
===========================================
+ Hits          5731     6906    +1175     
- Misses         183      193      +10     
+ Partials       210      208       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lucashuy lucashuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for opening this PR to add State to EventSource and EventBridgeRule! Just had question regarding one of the behaviours

@lucashuy lucashuy added area/event-source type/new-property area/event-bridge and removed stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Sep 13, 2022
Copy link
Contributor

@lucashuy lucashuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, this looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants