Skip to content

test: Add tests for intrinsics support for DefinitionBody #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2022
Merged

test: Add tests for intrinsics support for DefinitionBody #2407

merged 2 commits into from
Jun 3, 2022

Conversation

torresxb1
Copy link
Contributor

@torresxb1 torresxb1 commented May 30, 2022 •
edited by hawflau
Loading

Issue #, if available:

Description of changes:
Adding missing end-to-end test to make sure we keep supporting intrinsics where we currently support them in DefinitionBody.

Description of how you validated changes:

Checklist:

  • Add/update unit tests using:
  • Add/update integration tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@torresxb1 torresxb1 marked this pull request as draft May 31, 2022 16:10
@hawflau hawflau marked this pull request as ready for review June 3, 2022 16:28
torresxb1
torresxb1 commented Jun 3, 2022
View reviewed changes
Copy link
Contributor Author

@torresxb1 torresxb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub doesn't let me approve my own PR but LGTM 😂

@hawflau hawflau merged commit b8878b1 into aws:develop Jun 3, 2022
@torresxb1 torresxb1 deleted the definition-body-intrinsics-support-tests branch June 3, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawflau hawflau hawflau approved these changes

+1 more reviewer

@jfuss jfuss jfuss approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torresxb1 @hawflau @jfuss