Skip to content

Conversation

torresxb1
Copy link
Contributor

Issue #, if available:

Description of changes:
InvalidTemplateException would be unhandled before unless it was raised already wrapped with InvalidDocumentException (as we often do, e.g. in swagger.py). This should catch it and wrap it.

Description of how you validated changes:

Checklist:

  • Add/update unit tests using:
  • Add/update integration tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@torresxb1 torresxb1 requested review from jfuss and mildaniel May 2, 2022 22:34
@jfuss jfuss merged commit 8730d26 into aws:develop May 3, 2022
@torresxb1 torresxb1 deleted the handle_invalid_template branch May 9, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants