Skip to content

chore: Update PR template wording #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2022
Merged

chore: Update PR template wording #2383

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d131e0
Add checkbox for intrinsic validation changes
mildaniel Apr 19, 2022
137fd1e
Fix test
mildaniel Apr 21, 2022
cbd19a4
Update PR template wording
mildaniel Apr 21, 2022
46fd4a8
Resolve conflicts
mildaniel Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
- [ ] Update documentation
- [ ] Verify transformed template deploys and application functions as expected
- [ ] Do these changes include any template validations?
- [ ] Does this code change include validation to intrinsics that were not previously validated by SAM? (If unsure, please review [Intrinsic Functions](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference.html) before proceeding).
- [ ] Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review [Intrinsic Functions](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference.html) before proceeding).
- [ ] Does the pull request ensure that intrinsics remain functional with the new validations?

*Examples?*
Expand Down