Skip to content

Conversation

torresxb1
Copy link
Contributor

@torresxb1 torresxb1 commented Feb 22, 2022

Issue #, if available:

Description of changes:
A couple of places made an assumption of only getting the "then" case of an IF intrinsic. This affected a few integrations in swagger.py and openapi.py. The idea of the fix is to get both the "then" and "else" cases, and apply integrations to both.

Description of how you validated changes:

Checklist:

  • Add/update unit tests using:
  • Add/update integration tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2022

Codecov Report

Merging #2330 (bede899) into develop (e7a1496) will increase coverage by 0.85%.
The diff coverage is 98.20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2330      +/-   ##
===========================================
+ Coverage    93.58%   94.43%   +0.85%     
===========================================
  Files           90       97       +7     
  Lines         6124     7063     +939     
  Branches      1260     1454     +194     
===========================================
+ Hits          5731     6670     +939     
- Misses         183      185       +2     
+ Partials       210      208       -2     
Impacted Files Coverage Δ
samtranslator/model/api/api_generator.py 94.38% <92.95%> (+0.02%) ⬆️
samtranslator/__init__.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/dialup.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/feature_toggle.py 100.00% <100.00%> (+12.16%) ⬆️
samtranslator/intrinsics/actions.py 98.78% <100.00%> (+0.06%) ⬆️
samtranslator/intrinsics/resource_refs.py 95.83% <100.00%> (-0.17%) ⬇️
samtranslator/metrics/method_decorator.py 100.00% <100.00%> (ø)
samtranslator/metrics/metrics.py 100.00% <100.00%> (ø)
samtranslator/model/__init__.py 97.63% <100.00%> (-0.02%) ⬇️
samtranslator/region_configuration.py 77.77% <0.00%> (-22.23%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2956d26...bede899. Read the comment docs.

@torresxb1 torresxb1 merged commit 87d2a88 into aws:develop Feb 22, 2022
@torresxb1 torresxb1 deleted the if-paths-fix branch February 22, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants