update validation for dead letter queue #2324
Merged
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moelasmar
requested changes
Feb 15, 2022
| "'DeadLetterQueue' requires Type and TargetArn properties to be specified.".format(valid_dlq_types), | ||
| ) | ||
|
|
||
| if not (isinstance(self.DeadLetterQueue.get("Type"), str)): |
There was a problem hiding this comment.
can you update this method to validate that the DeadLetterQueue is of type Dict, and if not raise a validation error.
There was a problem hiding this comment.
I don't know this is necessary as this is already handled by sam. And this error is thrown when DeadLetterQueue is not dict Type of property 'DeadLetterQueue' is invalid.
There was a problem hiding this comment.
not sure where I can find this error, but I found this usage where we just check that the self.DeadLetterQueue is not None
serverless-application-model/samtranslator/model/sam_resources.py
Lines 139 to 140 in cae2729
There was a problem hiding this comment.
thanks @jonife for the clarification
moelasmar
approved these changes
Feb 17, 2022
jfuss
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Update validation for dlq
Description of how you validated changes:
Checklist:
make prpassesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.